Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper translation for manageiq_providers_cloud_manager_vms #16666

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

gtanzillo
Copy link
Member

So that it appears as "Instances" in report and expression editor list.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1513559

so that it appears as "Instances" in report and expression editor list.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1513559
@gtanzillo
Copy link
Member Author

Before -
manageiq_filters

After -
manageiq_filters_after

@miq-bot
Copy link
Member

miq-bot commented Dec 14, 2017

Checked commit gtanzillo@08c93eb with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@carbonin carbonin self-assigned this Dec 15, 2017
@carbonin carbonin added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 15, 2017
@carbonin carbonin merged commit 2da3d19 into ManageIQ:master Dec 15, 2017
simaishi pushed a commit that referenced this pull request Dec 18, 2017
Add proper translation for manageiq_providers_cloud_manager_vms
(cherry picked from commit 2da3d19)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527092
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 1cb8ecb5aae4d315e4d760abb2eb126287ad818e
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Fri Dec 15 16:36:42 2017 -0500

    Merge pull request #16666 from gtanzillo/translation-for-cloud-vms
    
    Add proper translation for manageiq_providers_cloud_manager_vms
    (cherry picked from commit 2da3d193ebbea89483217bac8bf68dfc7996f976)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants