Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manageiq_connection as an extra_var key sent through services #16668

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Add manageiq_connection as an extra_var key sent through services #16668

merged 1 commit into from
Dec 19, 2017

Conversation

syncrou
Copy link
Contributor

@syncrou syncrou commented Dec 14, 2017 •
edited by mkanoor
Loading

Duplicate as much as possible the extra_vars passed from a service as what is passed from automate.
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1527679

@syncrou
Copy link
Contributor Author

syncrou commented Dec 14, 2017

@miq-bot add_label enhancement, wip

@miq-bot assign @mkanoor

cc - @bzwei @gmcculloug

@miq-bot miq-bot changed the title Add manageiq_connection as an extra_var key sent through services [WIP] Add manageiq_connection as an extra_var key sent through services Dec 14, 2017
syncrou
syncrou commented Dec 14, 2017
View reviewed changes
app/models/service_ansible_playbook.rb
}.merge(request_options_extra_vars)
end

def manageiq_connection_env
Copy link
Contributor Author

@syncrou syncrou Dec 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good way for us to share this method with automate?

@syncrou
Copy link
Contributor Author

syncrou commented Dec 14, 2017

@miq-bot add_label services

@miq-bot
Copy link
Member

miq-bot commented Dec 14, 2017

Checked commit syncrou@50b08b4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@syncrou
Copy link
Contributor Author

syncrou commented Dec 14, 2017

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Add manageiq_connection as an extra_var key sent through services Add manageiq_connection as an extra_var key sent through services Dec 14, 2017
@miq-bot miq-bot removed the wip label Dec 14, 2017
@bzwei
Copy link
Contributor

bzwei commented Dec 14, 2017

Is backward comparability the reason you want to duplicate connection vars in both manageiq and manageiq_connection? We should deprecate them from manageiq.

@syncrou
Copy link
Contributor Author

syncrou commented Dec 15, 2017

Old playbooks that don't use our modules need manageiq while the new playbooks using the modules will be educated to use manageiq_connection.

With this change all documentation can encourage the use of manageiq_connection while still supporting the older playbooks that originally could only use manageiq.

The only true way to deprecate manageiq would be for a user to modify their existing playbook which most likely wouldn't happen. We'll handle the 'deprecation` from an education perspective as opposed to a code change.

@mkanoor mkanoor merged commit 17b389f into ManageIQ:master Dec 19, 2017
simaishi pushed a commit that referenced this pull request Jan 3, 2018
@mkanoor @simaishi
Merge pull request #16668 from syncrou/syncronize_with_automation
108d861 
Add manageiq_connection as an extra_var key sent through services
(cherry picked from commit 17b389f)

https://bugzilla.redhat.com/show_bug.cgi?id=1530635
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 108d8613fa3d104185298ead3d3ce170a270a058
Author: Madhu Kanoor <mkanoor@redhat.com>
Date:   Tue Dec 19 16:15:31 2017 -0500

    Merge pull request #16668 from syncrou/syncronize_with_automation
    
    Add manageiq_connection as an extra_var key sent through services
    (cherry picked from commit 17b389f30eec2a5b57deda6d29edd043d14dd1db)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530635

@agrare agrare added this to the Sprint 76 Ending Jan 1, 2018 milestone Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzwei bzwei bzwei approved these changes

@mkanoor mkanoor mkanoor approved these changes

Assignees

@mkanoor mkanoor

Labels
enhancement gaprindashvili/backported lifecycle/services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@syncrou @miq-bot @bzwei @simaishi @mkanoor @agrare