Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation to resolve ambiguous Provider:Type field #16673

Merged

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Dec 15, 2017

There are 2 attributes ExtManagementSystem#type and ExtManagementSystem#emstype_descriptionwhich translated to the same name Provider:Type in expression builder.

This PR updates translation to resolve ambiguous Provider:Type field in expression builder

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1514503

Before:
before

After:
after

@miq-bot add-label bug, reporting, gaprindashvili/yes, fine/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 15, 2017

@yrudman Cannot apply the following labels because they are not recognized: reportin, ggaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 15, 2017

Checked commit yrudman@75d828d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@yrudman
Copy link
Contributor Author

yrudman commented Dec 15, 2017

@miq-bot assign @gtanzillo

@gtanzillo gtanzillo added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 21, 2017
@gtanzillo gtanzillo merged commit fa4b71b into ManageIQ:master Dec 21, 2017
@yrudman yrudman deleted the resolve-ambiguous-filed-name-in-providers branch December 21, 2017 21:19
simaishi pushed a commit that referenced this pull request Jan 3, 2018
…n-providers

Update translation to resolve ambiguous Provider:Type field
(cherry picked from commit fa4b71b)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530685
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit c510101f2d902d6f799b1146237f1a9a7c72b732
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Dec 21 15:33:30 2017 -0500

    Merge pull request #16673 from yrudman/resolve-ambiguous-filed-name-in-providers
    
    Update translation to resolve ambiguous Provider:Type field
    (cherry picked from commit fa4b71b71b7b7da84bfd3972982d6ec4407da449)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530685

simaishi pushed a commit that referenced this pull request Jan 4, 2018
…n-providers

Update translation to resolve ambiguous Provider:Type field
(cherry picked from commit fa4b71b)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531178
@simaishi
Copy link
Contributor

simaishi commented Jan 4, 2018

Fine backport details:

$ git log -1
commit 4ba62eeb063a5ee1fd17244e556fc7f6e30e94bb
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Dec 21 15:33:30 2017 -0500

    Merge pull request #16673 from yrudman/resolve-ambiguous-filed-name-in-providers
    
    Update translation to resolve ambiguous Provider:Type field
    (cherry picked from commit fa4b71b71b7b7da84bfd3972982d6ec4407da449)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531178

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…d-name-in-providers

Update translation to resolve ambiguous Provider:Type field
(cherry picked from commit fa4b71b)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants