Stop cashing fields for ChargebackVm report #16683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue is the CloudVolume type are defined as dynamic methods on ChargebackVm and there is no way how to remove these dynamically field from ChargebackVM - so I overwrite the method attribute_names and I am filtering only existing volume types
|
@lpichler Cannot apply the following label because they are not recognized: bloker |
|
@miq-bot add_label gaprindashvili/yes |
|
Checked commits lpichler/manageiq@3bcad07~...c10c5a7 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Dec 19, 2017
|
@miq-bot add_label blocker |
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
…ckvm_report Stop cashing fields for ChargebackVm report (cherry picked from commit 6352baf) https://bugzilla.redhat.com/show_bug.cgi?id=1517956
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we added #16321 as dynamic fields.
We are using memoizing for keeping list of attributes - on model MiqExpression.
so I stopped memoizing to possibility each get exactly what is in DB for ChargebackVm.
second issue on model ChargebackVm - when we are adding dynamic fields to the ChargebackVm - it is like adding a method dynamically to class - but there is no mechanism how to remove them.
So I overwrite method
ChargebackVm.attribute_names- and this method will be always return actual field what are in DB - non-existing are filtered out.@miq-bot add_label chargeback, bug, bloker
@miq-bot assign @gtanzillo
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1517956