Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add product/compare/*.yaml to string extraction #16691

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Add product/compare/*.yaml to string extraction #16691

merged 1 commit into from
Dec 22, 2017

Conversation

mzazrivec
Copy link
Contributor

This change is to make sure strings from product/compare/*.yaml files will be extracted and translated.

gaprindashvili/yes

https://bugzilla.redhat.com/show_bug.cgi?id=1495849

@miq-bot
Copy link
Member

miq-bot commented Dec 19, 2017

Checked commit mzazrivec@b4270bd with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

lib/tasks/locale.rake

@mzazrivec mzazrivec mentioned this pull request Dec 20, 2017
Merged
@martinpovolny martinpovolny merged commit 069caea into ManageIQ:master Dec 22, 2017
@martinpovolny martinpovolny self-assigned this Dec 22, 2017
@martinpovolny martinpovolny added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 22, 2017
simaishi pushed a commit that referenced this pull request Jan 3, 2018
@martinpovolny @simaishi
Merge pull request #16691 from mzazrivec/add_product_compare_to_strin…
c1c6be1 
…g_extraction

Add product/compare/*.yaml to string extraction
(cherry picked from commit 069caea)

https://bugzilla.redhat.com/show_bug.cgi?id=1495849
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit c1c6be14df778e66c3884f5684de9253032adf6e
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Fri Dec 22 10:43:23 2017 +0100

    Merge pull request #16691 from mzazrivec/add_product_compare_to_string_extraction
    
    Add product/compare/*.yaml to string extraction
    (cherry picked from commit 069caeaddbe7482a94a09fde7ce4e021202a1c13)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1495849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
gaprindashvili/backported internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzazrivec @miq-bot @simaishi @martinpovolny