Fix email issue in miq_provision_quota_mixin active_provision by_owner method. #16693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VM provisions. Removed to_s from get_option(:owner_email) to cause an error if email is nil. https://bugzilla.redhat.com/show_bug.cgi?id=1509977
|
@miq-bot add_label bug, fine/yes, gaprindashvili/yes, blocker |
|
Checked commit tinaafitz@faa9ad4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@gmcculloug Please review. |
gmcculloug
approved these changes
Dec 20, 2017
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
Fix email issue in miq_provision_quota_mixin active_provision by_owner method. (cherry picked from commit 748ba9b) https://bugzilla.redhat.com/show_bug.cgi?id=1530644
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 4, 2018
Fix email issue in miq_provision_quota_mixin active_provision by_owner method. (cherry picked from commit 748ba9b) https://bugzilla.redhat.com/show_bug.cgi?id=1531161
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Fix email issue in miq_provision_quota_mixin active_provision by_owner method. (cherry picked from commit 748ba9b) https://bugzilla.redhat.com/show_bug.cgi?id=1531161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The active_provisions_by_owner method was getting a "no implicit conversion of nil into String" error for service provisioning. The error occurs when the Service request.requester.email is nil.
Content PR protects against calling the active_provisions_by_owner method without the requester email.
ManageIQ/manageiq-content#230
Changed miq_provision_quota_mixin to call the request_owner_email method to handle getting email for Services and VM provisions. Removed to_s from get_option(:owner_email) to cause an error if email is nil.
https://bugzilla.redhat.com/show_bug.cgi?id=1509977