Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes wrong number of arguments in purge_queue #16706

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Fixes wrong number of arguments in purge_queue #16706

merged 1 commit into from
Dec 21, 2017

Conversation

hsong-rh
Copy link
Contributor

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

Checked commit hsong-rh@b798398 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@hsong-rh
Copy link
Contributor Author

@agrare @roliveri Please review.

@agrare agrare self-assigned this Dec 20, 2017
agrare
agrare approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agrare agrare merged commit ffb458e into ManageIQ:master Dec 21, 2017
@hsong-rh hsong-rh deleted the purge_queue_args branch December 21, 2017 14:29
simaishi pushed a commit that referenced this pull request Jan 3, 2018
@agrare @simaishi
Merge pull request #16706 from hsong-rh/purge_queue_args
86314c6 
Fixes wrong number of arguments in purge_queue
(cherry picked from commit ffb458e)
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 86314c648f7f6dcfffe9d9986f3895cbb9d57f81
Author: Adam Grare <agrare@redhat.com>
Date:   Thu Dec 21 09:19:14 2017 -0500

    Merge pull request #16706 from hsong-rh/purge_queue_args
    
    Fixes wrong number of arguments in purge_queue
    (cherry picked from commit ffb458e15fe5d47d10797508c67e97587e2a517f)

@agrare agrare added this to the Sprint 76 Ending Jan 1, 2018 milestone Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@roliveri roliveri roliveri approved these changes

Assignees

@agrare agrare

Labels
blocker bug core gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hsong-rh @miq-bot @simaishi @roliveri @agrare