Added get_targets_for_ base class methods #16707

syncrou · 2017-12-20T22:04:52Z

Turns on RBAC filtering by default at the base class level for all allowed_ methods_ in the ManageIQ::CloudManager class.

https://bugzilla.redhat.com/show_bug.cgi?id=1514237

Steps for Testing/QA

Add tags to a user for use on a Cloud provider*
Login in as that user and Provision an Instance
Only Tagged objects should appear in the dropdowns

There are specific providers that have already overridden the Base Class methods and in some cases the overridden methods do not yet support RBAC filtering. e.g. Amazon and the allowed_floating_ips method.

syncrou · 2017-12-20T22:05:41Z

@miq-bot assign @gmcculloug

@miq-bot add_label providers, bz, blocker, wip

miq-bot · 2017-12-20T22:06:25Z

@syncrou Cannot apply the following label because they are not recognized: bz

syncrou · 2017-12-20T22:07:27Z

@miq-bot add_label bug

syncrou · 2017-12-21T19:44:38Z

@miq-bot remove_label wip

gmcculloug · 2017-12-21T20:11:01Z

spec/models/manageiq/providers/cloud_manager/provision_workflow_spec.rb

+    allow_any_instance_of(User).to receive(:get_timezone).and_return(Time.zone)
+    allow_any_instance_of(ManageIQ::Providers::CloudManager::ProvisionWorkflow).to receive(:update_field_visibility)
+    wf = described_class.new({:src_vm_id => template.id}, admin.userid)
+    wf


Saw this on the provider version of the spec. Drop the wf variable and just let described_class.new return the object.

gmcculloug · 2017-12-21T20:55:23Z

spec/models/manageiq/providers/cloud_manager/provision_workflow_spec.rb

+  let(:workflow) do
+    stub_dialog
+    allow_any_instance_of(User).to receive(:get_timezone).and_return(Time.zone)
+    allow_any_instance_of(ManageIQ::Providers::CloudManager::ProvisionWorkflow).to receive(:update_field_visibility)


Replace ManageIQ::Providers::CloudManager::ProvisionWorkflow with described_class.

gmcculloug · 2017-12-21T21:15:31Z

spec/models/manageiq/providers/cloud_manager/provision_workflow_spec.rb

+
+  let(:admin) { FactoryGirl.create(:user_with_group) }
+  let(:ems) { FactoryGirl.create(:ems_amazon) }
+  let(:template) { FactoryGirl.create(:template_amazon, :name => "template", :ext_management_system => ems) }


Can we use generic factories where possible. Example: template_cloud.

This we need a little more work before we can replace all of them.

gmcculloug · 2017-12-22T15:32:19Z

spec/factories/availability_zone.rb

@@ -3,6 +3,8 @@
    sequence(:name)     { |n| "availability_zone_#{seq_padded_for_sorting(n)}" }
  end

+  factory :availability_zone_generic, :parent => :availability_zone


@syncrou The tests pass locally if I just use availability_zone in the tests. Is this needed for some reason?

@gmcculloug - I'll do more testing - I was seeing failures without the :parent value in place.

1. Turns on RBAC filtering by default at the base class level for all allowed_ methods in the CloudManager class https://bugzilla.redhat.com/show_bug.cgi?id=1514237

miq-bot · 2018-01-08T21:31:01Z

Some comments on commits syncrou/manageiq@14830a7~...449f2ee

spec/models/manageiq/providers/cloud_manager/provision_workflow_spec.rb

⚠️ - 10 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
⚠️ - 9 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

miq-bot · 2018-01-08T21:31:25Z

Checked commits syncrou/manageiq@14830a7~...449f2ee with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

Added get_targets_for_ base class methods (cherry picked from commit 7783ec1) https://bugzilla.redhat.com/show_bug.cgi?id=1532646

simaishi · 2018-01-09T13:59:17Z

Gaprindashvili backport details:

$ git log -1
commit 3c5088d165321c2043dedf0c521872e5389823cf
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Jan 8 18:05:39 2018 -0500

    Merge pull request #16707 from syncrou/tag_filter_cloud_stuffs
    
    Added get_targets_for_ base class methods
    (cherry picked from commit 7783ec1d9839ffffe1a915e794e3d75b40f40e0d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1532646

Added get_targets_for_ base class methods (cherry picked from commit 7783ec1) https://bugzilla.redhat.com/show_bug.cgi?id=1533139

simaishi · 2018-01-10T14:58:38Z

Fine backport details:

$ git log -1
commit 271d75c8a3e5fa6e8cdeff926dfda9ba3028c38a
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Jan 8 18:05:39 2018 -0500

    Merge pull request #16707 from syncrou/tag_filter_cloud_stuffs
    
    Added get_targets_for_ base class methods
    (cherry picked from commit 7783ec1d9839ffffe1a915e794e3d75b40f40e0d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1533139

Added get_targets_for_ base class methods (cherry picked from commit 7783ec1) https://bugzilla.redhat.com/show_bug.cgi?id=1533139

miq-bot assigned gmcculloug Dec 20, 2017

miq-bot changed the title ~~Added get_targets_for_ base class methods~~ [WIP] Added get_targets_for_ base class methods Dec 20, 2017

miq-bot added blocker providers wip labels Dec 20, 2017

miq-bot added the bug label Dec 20, 2017

miq-bot changed the title ~~[WIP] Added get_targets_for_ base class methods~~ Added get_targets_for_ base class methods Dec 21, 2017

miq-bot removed the wip label Dec 21, 2017

syncrou force-pushed the tag_filter_cloud_stuffs branch from 38514ce to 98d6517 Compare December 21, 2017 19:46

gmcculloug reviewed Dec 21, 2017

View reviewed changes

syncrou force-pushed the tag_filter_cloud_stuffs branch 5 times, most recently from f310da7 to a4de244 Compare December 21, 2017 22:15

gmcculloug reviewed Dec 22, 2017

View reviewed changes

This was referenced Jan 2, 2018

[WIP] Adds spec for cloud network with availability zone ManageIQ/manageiq-providers-amazon#380

Closed

Changes cloud network list to follow availability zone rules #16688

Merged

syncrou force-pushed the tag_filter_cloud_stuffs branch 3 times, most recently from 89b4d4c to 7374f01 Compare January 8, 2018 21:00

syncrou added 2 commits January 8, 2018 16:27

Added get_targets_for base class methods

14830a7

1. Turns on RBAC filtering by default at the base class level for all allowed_ methods in the CloudManager class https://bugzilla.redhat.com/show_bug.cgi?id=1514237

Added Specs around the RBAC'd allowed_ methods

449f2ee

syncrou force-pushed the tag_filter_cloud_stuffs branch from 7374f01 to 449f2ee Compare January 8, 2018 21:28

syncrou closed this Jan 8, 2018

syncrou reopened this Jan 8, 2018

gmcculloug merged commit 7783ec1 into ManageIQ:master Jan 8, 2018

gmcculloug added fine/yes labels Jan 8, 2018

gmcculloug added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 8, 2018

simaishi pushed a commit that referenced this pull request Jan 9, 2018

Merge pull request #16707 from syncrou/tag_filter_cloud_stuffs

3c5088d

Added get_targets_for_ base class methods (cherry picked from commit 7783ec1) https://bugzilla.redhat.com/show_bug.cgi?id=1532646

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Jan 9, 2018

simaishi pushed a commit that referenced this pull request Jan 10, 2018

Merge pull request #16707 from syncrou/tag_filter_cloud_stuffs

271d75c

Added get_targets_for_ base class methods (cherry picked from commit 7783ec1) https://bugzilla.redhat.com/show_bug.cgi?id=1533139

simaishi added fine/backported and removed fine/yes labels Jan 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added get_targets_for_ base class methods #16707

Added get_targets_for_ base class methods #16707

syncrou commented Dec 20, 2017 •

edited

Loading

syncrou commented Dec 20, 2017

miq-bot commented Dec 20, 2017

syncrou commented Dec 20, 2017

syncrou commented Dec 21, 2017

gmcculloug Dec 21, 2017

gmcculloug Dec 21, 2017

gmcculloug Dec 21, 2017

gmcculloug Dec 22, 2017

syncrou Jan 8, 2018

miq-bot commented Jan 8, 2018

miq-bot commented Jan 8, 2018

simaishi commented Jan 9, 2018

simaishi commented Jan 10, 2018

Added get_targets_for_ base class methods #16707

Added get_targets_for_ base class methods #16707

Conversation

syncrou commented Dec 20, 2017 • edited Loading

Steps for Testing/QA

syncrou commented Dec 20, 2017

miq-bot commented Dec 20, 2017

syncrou commented Dec 20, 2017

syncrou commented Dec 21, 2017

gmcculloug Dec 21, 2017

Choose a reason for hiding this comment

gmcculloug Dec 21, 2017

Choose a reason for hiding this comment

gmcculloug Dec 21, 2017

Choose a reason for hiding this comment

gmcculloug Dec 22, 2017

Choose a reason for hiding this comment

syncrou Jan 8, 2018

Choose a reason for hiding this comment

miq-bot commented Jan 8, 2018

miq-bot commented Jan 8, 2018

simaishi commented Jan 9, 2018

simaishi commented Jan 10, 2018

syncrou commented Dec 20, 2017 •

edited

Loading