Add rake script to export/import roles #16717
Conversation
|
Moving over to @gtanzillo to review as this is closer to core. Maybe @carbonin can help out here as well, he reviewed a previous import/export rake task PR. |
|
@gtanzillo @carbonin I'm not sure why the travis-ci build is failing. Any ideas or pointers? The failures aren't in any of the files I've made a change to. |
| let(:role_one_name) { 'Role Import Test' } | ||
| let(:role_two_name) { 'Role Import Test 2' } | ||
|
|
||
| EvmSpecHelper.seed_specific_product_features(%w( |
There was a problem hiding this comment.
I would be willing to bet that this is causing your spec failures. This should be in a before block.
|
Thanks @carbonin that fixed the travis-ci errors. |
|
@gtanzillo @carbonin I know you guys are busy, but can one of you review this PR. Thanks, |
lib/task_helpers/exports/roles.rb
Outdated
| Exports.exclude_attributes(role.attributes, %w(created_at updated_at id)).merge('feature_identifiers' => role.feature_identifiers.sort) | ||
| end | ||
|
|
||
| roles.compact |
There was a problem hiding this comment.
I think you need #compact! here. Or you could add #compact after the end above.
As is, this line doesn't do anything.
There was a problem hiding this comment.
Thanks for catching this. I've moved the #compact to after the end
lib/task_helpers/imports/roles.rb
Outdated
| begin | ||
| roles = YAML.load_file(fname) | ||
| import_roles(roles) | ||
| rescue => e |
There was a problem hiding this comment.
Is there more specific exception we can rescue here?
There was a problem hiding this comment.
I don't know what all of the exceptions are that could be raised so I used the more generic to catch any error with the import.
| end | ||
|
|
||
| after do | ||
| # FileUtils.remove_entry export_dir |
There was a problem hiding this comment.
Do we need this or can we just remove this block?
There was a problem hiding this comment.
It's needed so that when the test runs the directory that is created is removed. I had commented it out when I was testing the spec files and forgot to uncomment it before committing. I've uncommented the line.
lib/task_helpers/imports/roles.rb
Outdated
|
|
||
| def import_roles(roles) | ||
| roles.each do |r| | ||
| r['miq_product_feature_ids'] = MiqProductFeature.all.collect do |f| |
There was a problem hiding this comment.
It would be better to pull the MiqProductFeature.all out of the loop and put it in a var so that it doesn't get called for every iteration.
lib/task_helpers/imports/roles.rb
Outdated
| def import(options = {}) | ||
| return unless options[:source] | ||
|
|
||
| available_features = MiqProductFeature.all |
There was a problem hiding this comment.
@branic This is good but I think you should move it into the method that needs it instead of passing it as an argument. You can just put it right above line 23 below, just above the roles.each do |r| line.
|
Checked commits https://github.com/branic/manageiq/compare/5c84eaf7836b38795e1cf01f6c4ec24b0eb89b70~...21b299af24b641d95a80d3abefd23a0e473a0d2a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
These rake scripts and classes provide functionality for exporting/importing of the following ManageIQ object types:
This PR uses the framework that was implemented for PRs #14126 and #15256 to export/import other ManageIQ object types.
These scripts are based on the CFME RH Consulting Scripts and are used by Red Hat consultants to enable storing customizations in Git and maintaining customizations between environments (e.g. dev/qa/prod) for an SDLC lifecycle.