Remove MiddlewareManager Alerts

[cfcosta]

This removes all the MiddlewareServer/Hawkular alerts, while also removing the logic to process it. This is a part of the process of phasing out MiddlewareManager.

Relates to (just a small glimpse on what's being done on this front, there's other PRs not mentioned here):
#16698
ManageIQ/manageiq-ui-classic#3142
ManageIQ/manageiq-ui-classic#3120
#16701
#16712
ManageIQ/manageiq-ui-classic#3118

Screenshots

Before:

After:

[cfcosta]

Please note that I didn't test it manually because the Control Explorer is failing per #16730. Will do as soon as it is fixed.

@abonas @agrare can you review?

[abonas]

@cfcosta the blocking issue is resolved, so please verify the code before review.
@israel-hdez please review

[cfcosta]

@abonas Done, everything is working as expected. Alerts are not on the listing anymore.

[abonas]

@cfcosta please add a screenshot of the affected UI

[israel-hdez]

It is quite fine. Is there any complementary PR? I understand this is removing MW alert conditions and also some backend code. But I don't understand how the MW nodes are being removed from the control explorer.

[cfcosta]

@israel-hdez you were right, I forgot to remove it from the listing on the constant. That is fixed now.

@abonas updated the description for screenshots. Is that ok or do you need others?

[abonas]

@cfcosta are the screenshots representing only the "after the change" state?

[abonas]

@cfcosta what's the status of this PR? is it ready for review/merge by core?

[abonas]

@miq-bot add_label gaprindashvili/yes

[lfu]

Should MiddlewareServer be removed from this line in this PR?

[cfcosta]

@abonas sorry for the delay. Yeah, those screenshots represent the final state. I'm updating it to include the Before as well. And it is ready to merge/review.

@lfu good catch, fixed.

[miq-bot]

Checked commits cfcosta/manageiq@ac5d338~...bc205cc with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 1 offense detected

app/models/miq_alert.rb

• ❗ - Line 544, Col 21 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

[lfu]

@cfcosta Can you take a look at Travis failure?

[cfcosta]

  1) VmdbDatabaseConnection is blocked
     Failure/Error: raise "Lock is not blocking"
     
     RuntimeError:
       Lock is not blocking
     # ./spec/models/vmdb_database_connection_spec.rb:77:in `block (2 levels) in <top (required)>'

This is the failure, does not seem related, and I'm not sure what this is referring to.

[agrare]

@cfcosta going to bounce the test, we're discussing the error in the manageiq/core room on gitter

[lfu]

@gmcculloug LGTM 👍

[himdel]

This caused ui travis failures, fixed by ManageIQ/manageiq-ui-classic#3260 .

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 6a9b471c0d25bf0d3b8bc69d5aae9bdb89b1e9ae
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Jan 16 13:11:37 2018 -0500

    Merge pull request #16729 from cfcosta/remove-middleware-alerts
    
    Remove MiddlewareManager Alerts
    (cherry picked from commit e5192926f735bea28b495afd6cba757e2c1d1a83)