Add more translations for cloud resources and templates #16744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
reviewed
Jan 4, 2018
locale/en.yml
Outdated
| @@ -1052,8 +1052,10 @@ en: | |||
| miq_custom_attribute: EVM Custom Attribute | |||
| miq_custom_attributes: EVM Custom Attributes | |||
| miq_event_definition: Event | |||
| manageiq_providers_cloud_manager: Cloud Provider | |||
There was a problem hiding this comment.
I agree, but we are doing that elsewhere in the file. However, looking through all the entries I see that in some places Provider is being used and in other places Manager is used.
It probably makes sense to use Manager for these going forward. I'll make the change.
so they appear properly in report and expression editor lists. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1513559 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527092
gtanzillo
force-pushed
the
more-translations
branch
from
5724456
to
e364f31
Compare
|
Checked commit gtanzillo@e364f31 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
Jan 4, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 4, 2018
Add more translations for cloud resources and templates (cherry picked from commit 5cbc0b8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527092
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so they appear properly in report and expression editor lists.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1513559
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527092