Adds unique within region check to pxe image type names #16745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
pxe_image_type_unique_in_region
branch
from
163dd91
to
2220847
Compare
d-m-u
changed the title
bdunne
reviewed
Jan 29, 2018
app/models/pxe_image_type.rb
Outdated
| @@ -4,7 +4,7 @@ class PxeImageType < ApplicationRecord | |||
| has_many :windows_images | |||
| has_many :iso_images | |||
|
|
|||
| validates_uniqueness_of :name | |||
| validates_uniqueness_of :name, :unique_within_region => true, :message => "Pxe Image Type name (%{value}) has already been taken" | |||
There was a problem hiding this comment.
Was there a problem with the default message?
There was a problem hiding this comment.
Absolutely, it doesn't distinguish between the pxe_image_type name and the name of the customization_template.
d-m-u
force-pushed
the
pxe_image_type_unique_in_region
branch
2 times, most recently
from
5d9e7d5
to
f657018
Compare
d-m-u
force-pushed
the
pxe_image_type_unique_in_region
branch
from
f657018
to
130f087
Compare
|
Checked commit d-m-u@130f087 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure these template names should be unique by region.
#16739 led me to this issue.