Fix for failure to update service dialog - Couldn't find DialogField without an ID #16753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclarizio
force-pushed
the
BZ1518942
branch
2 times, most recently
from
cfa71c6
to
93a15d7
Compare
|
Checked commits eclarizio/manageiq@97734c9~...e442aa8 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 9, 2018
Fix for failure to update service dialog - Couldn't find DialogField without an ID (cherry picked from commit cb5544d) https://bugzilla.redhat.com/show_bug.cgi?id=1532642
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that when creating or editing a dialog, whenever you add a dynamic field, the field does not yet have an ID because it hasn't been saved. So we must build the association list by names and then after saving all of the fields build the associations afterwards. This PR will need to be coordinated with this ui-components PR for the bug to be fully fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1518942
@miq-bot add_label gaprindashvili/yes, bug
@d-m-u @gmcculloug Please review