Add MiqWdigetSet to Dashboard dictionary translation #16784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, can be merged after Travis turns green |
|
Checked commit GregP@538e65d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 10, 2018
Add MiqWdigetSet to Dashboard dictionary translation (cherry picked from commit cab9cf9) https://bugzilla.redhat.com/show_bug.cgi?id=1513603
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and adds missing dictionary definition for Dashboard (MiqWidgetSet) for Delete action in UI.
This PR is for Delete Dashboard action code fix, please see related PR for Add/Edit actions here: ManageIQ/manageiq-ui-classic#2688
https://bugzilla.redhat.com/show_bug.cgi?id=1513603
Screen shot prior to code fix:
Screen shot post code fix:
