Adding apply config pattern feature #16796
Conversation
|
@bdunne Can you take a look on this? |
|
Sorry, I'm not familiar with the usage on the product_features file. Maybe @juliancheal can help? |
|
@agrare Can you take a look at this PR |
|
I'm with @bdunne I haven't had to touch the product features ping @h-kataria @martinpovolny |
|
@igorrran change looks good, are there going to be UI changes followed by this to have button visible in UI? |
|
@h-kataria Not for now. It's just to allow the operation via REST API. The implementation of the operation follow below: |
|
@igorrran in that case shouldn't this feature be moved under API section here https://github.com/igorrran/manageiq/blob/1299e8800add9948753aa1218da1189fc03da8c5/db/fixtures/miq_product_features.yml#L6539 |
|
@imtayadeway do you agree with my comment #16796 (comment) i am not sure if there are any other features in other sections that are exclusively for REST API only other than the ones in API section. |
|
@h-kataria yes, agreed! IIRC this was pulled out recently - there may be other features that belong here but have not been moved yet |
igorrran
force-pushed
the
add_feature_config_pattern
branch
from
1299e88
to
4a073ea
Compare
igorrran
force-pushed
the
add_feature_config_pattern
branch
from
4a073ea
to
ebbead0
Compare
|
Checked commit igorrran@ebbead0 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@h-kataria Ok. I moved the feature to the correct section. Does it look good? |
|
@igorrran we probably need to close this PR and re-open to have the travis tests run again. Looks like this could be approved when complete. Also note that the UI change has already been made, this PR is adding a REST path in addition to the UI workflow that was already added. ManageIQ/manageiq-ui-classic#2401 |
This PR is able to:
*Add apply config pattern feature