Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Authenticator to remove const manipulations #16869

Merged

Commits on Jan 23, 2018

  1. Refactor Authenticator to remove const manipulations

    After ManageIQ#16867, the
    DescendantLoader now works properly with non-AR models such as the
    Authenticator.  Much of the code in the Authenticator, such as
    require_nested and force_load_authenticator_for is just workarounds
    over the issues from DescendantLoader, so these can be removed.
    Additionally, the only caller of the authenticator_class was the
    validator, so this commit moves the validation code into the
    Authenticator class directly, allow us to make all of those
    authenticator_class methods private.
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537299
    Fryguy committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    dad746d View commit details
    Browse the repository at this point in the history