Don't dependent => destroy child managers #16871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destroying child_managers is orchestrated by the parent and destroying them prematurely leads to issues when the endpoints are shared between the two managers.
This was referenced Jan 23, 2018
|
Checked commit agrare@5e1bf77 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@agrare @Fryguy Created a BZ to track this change: https://bugzilla.redhat.com/show_bug.cgi?id=1538232. Please update as needed. |
simaishi
pushed a commit
that referenced
this pull request
Jan 24, 2018
Don't dependent => destroy child managers (cherry picked from commit 38225e1) https://bugzilla.redhat.com/show_bug.cgi?id=1538240
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destroying child_managers is orchestrated by the parent and destroying
them prematurely leads to issues when the endpoints are shared between
the two managers.
Example failure: https://travis-ci.org/ManageIQ/manageiq-providers-openstack/jobs/332446792#L2079-L2091
Other PRs:
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1538232