Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the human description for "cpu_used_delta_summation" #16878

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Jan 24, 2018

Update the human description for "cpu_used_delta_summation" to allow the correct selection of performance field for alerts.

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1495209

@lgalis
Copy link
Contributor Author

lgalis commented Jan 24, 2018

@miq-bot add_label internationalization
@gtanzillo - please review

@lgalis
Copy link
Contributor Author

lgalis commented Feb 10, 2018

@miq-bot add_label gaprindashvili/yes
@gtanzillo or @dclarizio - please review

@dclarizio
Copy link

@gtanzillo your suggestion for the new description seems to break the convention of the others around it. Should we alter this a bit to at least start with CPU - , maybe CPU - Total time usage (VMware) (ms)?

@lgalis lgalis force-pushed the change_cpu_used_delta_summation_description branch from 19bf224 to d200f09 Compare February 19, 2018 21:35
@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2018

Checked commit lgalis@d200f09 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@lgalis
Copy link
Contributor Author

lgalis commented Feb 19, 2018

@dclarizio - updated as requested

@dclarizio dclarizio added the bug label Feb 19, 2018
@dclarizio dclarizio self-assigned this Feb 19, 2018
@dclarizio dclarizio merged commit 0725871 into ManageIQ:master Feb 19, 2018
@dclarizio dclarizio added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 19, 2018
@lgalis lgalis deleted the change_cpu_used_delta_summation_description branch February 20, 2018 18:57
simaishi pushed a commit that referenced this pull request Mar 7, 2018
…_description

Update the  human description for "cpu_used_delta_summation"
(cherry picked from commit 0725871)

https://bugzilla.redhat.com/show_bug.cgi?id=1552794
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 24a89aca81729f9312c345e90343b7a0ed9f8be9
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Mon Feb 19 15:06:32 2018 -0800

    Merge pull request #16878 from lgalis/change_cpu_used_delta_summation_description
    
    Update the  human description for "cpu_used_delta_summation"
    (cherry picked from commit 0725871d347dc785d2288be41f97dedb0e56cf02)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants