Add back the missing IP address range in Virtual Private Cloud name. #16898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - thanks @lfu |
gmcculloug
reviewed
Jan 26, 2018
| end | ||
| else | ||
| load_ar_obj(src[:ems]).all_cloud_networks.each_with_object({}) do |cn, hash| | ||
| hash[cn.id] = cn.name | ||
| hash[cn.id] = cn.cidr.blank? ? cn.name : "#{cn.name} (#{cn.cidr})" |
There was a problem hiding this comment.
@lfu Would suggest DRYing up this naming logic since it gets repeated here as well as in some external repos.
def cloud_network_display_name(cn)
cn.cidr.blank? ? cn.name : "#{cn.name} (#{cn.cidr})"
end
lfu
force-pushed
the
ip_range_azure_1538696
branch
from
63a0b1b
to
95aa300
Compare
|
Checked commit lfu@95aa300 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Jan 26, 2018
bdunne
approved these changes
Jan 26, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 29, 2018
Add back the missing IP address range in Virtual Private Cloud name. (cherry picked from commit 32a131d) https://bugzilla.redhat.com/show_bug.cgi?id=1539730
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IP address range in Virtual Private Cloud name was accidentally removed here.
Includes ManageIQ/manageiq-providers-openstack#211.
Includes ManageIQ/manageiq-providers-google#46.
https://bugzilla.redhat.com/show_bug.cgi?id=1538696
@miq-bot add_label bug, gaprindashvili/yes
@miq-bot assign @gmcculloug
cc @bronaghs