Fix supports_launch_vnc_console? for VMWare VMs #16905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this statement assumes that a VM has an ext_management_system, resulting in an internal error showing up in the unsupported reason for vnc_console Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539429
|
Checked commit jntullo@63cb7d6 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Jan 29, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 29, 2018
Fix supports_launch_vnc_console? for VMWare VMs (cherry picked from commit 019fab4) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539942
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
supports_launch_vnc_console?method checksapi_versiononext_management_systembut not all of these VMs have an ems, resulting in an internal error showing up in the unsupported reason for vnc_console.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539429
@miq-bot assign @gtanzillo
@miq-bot add_label blocker, bug, gaprindashvili/yes