Add circular reference association check to import for ui update #16918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
d-m-u
force-pushed
the
adding_circ_ref_check_to_import
branch
from
1ccca0e
to
6c6e8e0
Compare
|
@eclarizio @bdunne can ya'll 👀 at this please for me, por favor? |
d-m-u
force-pushed
the
adding_circ_ref_check_to_import
branch
from
6c6e8e0
to
f28b5b1
Compare
d-m-u
force-pushed
the
adding_circ_ref_check_to_import
branch
from
f28b5b1
to
80a4756
Compare
bdunne
reviewed
Jan 31, 2018
| @@ -115,7 +123,7 @@ def build_association_list(dialog) | |||
| dialog["dialog_tabs"].flat_map do |tab| | |||
| tab["dialog_groups"].flat_map do |group| | |||
| group["dialog_fields"].flat_map do |field| | |||
| associations << { field["name"] => field["dialog_field_responders"] } unless field["dialog_field_responders"].nil? | |||
| associations << { field["name"] => field["dialog_field_responders"] } if field["dialog_field_responders"].present? | |||
There was a problem hiding this comment.
if field["dialog_field_responders"] is equivalent to unless field["dialog_field_responders"].nil?. present? changes that a little bit.
There was a problem hiding this comment.
I think we want present, though.
There was a problem hiding this comment.
Save via the UI results in there being empty arrays if there aren't associations and we don't want them in the association list if they're empty.
eclarizio
suggested changes
Jan 31, 2018
d-m-u
force-pushed
the
adding_circ_ref_check_to_import
branch
from
09648f6
to
06a3498
Compare
d-m-u
force-pushed
the
adding_circ_ref_check_to_import
branch
from
06a3498
to
0aaa8e5
Compare
|
Checked commits d-m-u/manageiq@80a4756~...0aaa8e5 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
eclarizio
approved these changes
Feb 22, 2018
|
@d-m-u Please add BZ link. |
simaishi
pushed a commit
that referenced
this pull request
Mar 22, 2018
Add circular reference association check to import for ui update (cherry picked from commit 4429472) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1559483
|
Gaprindashvili backport details: |
simaishi
added
gaprindashvili/backported
and removed
bugzilla needed
gaprindashvili/yes
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog field associations are checked for circular references on dialog import but this check needs to also be included in the main dialog validation on save for association creation via the classic ui.
https://bugzilla.redhat.com/show_bug.cgi?id=1559382