Make sure Containers Exist Before Processing #16922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label fine/yes |
|
@miq-bot add_label gaprindashvili/yes |
|
@miq-bot add_label bug |
jerryk55
changed the title
The crosslink code for the Swift Manager refresh parser attempts to loop through the set of containers for the manager without checking if any exist first. Fix by checking first.
The same check that was added to the crosslink code in the previous commit has to be added to the refresh parser cleanup code.
jerryk55
force-pushed
the
fix_swift_refresher_with_empty_containers
branch
from
d9f75d2
to
0579193
Compare
|
Checked commits jerryk55/manageiq@8fa42b2~...0579193 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@jerryk55 any tests you can add for this? |
|
@blomquisg this is a blocker for 5.8.3 |
roliveri
approved these changes
Feb 5, 2018
|
@blomquisg this is a hard thing to test - the environment has to be kind of screwed up to get yourself into this situation (I really don't think it should be a blocker personally). You have to have access to openstack but not to the swift containers that probably exist. |
simaishi
pushed a commit
that referenced
this pull request
Feb 6, 2018
…y_containers Make sure Containers Exist Before Processing (cherry picked from commit 530eb07) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542740
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Feb 6, 2018
…y_containers Make sure Containers Exist Before Processing (cherry picked from commit 530eb07) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542741
|
Fine backport details: |
This was referenced Feb 28, 2018
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…ith_empty_containers Make sure Containers Exist Before Processing (cherry picked from commit 530eb07) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crosslink code for the Swift Manager refresh parser
attempts to loop through the set of containers for the
manager without checking if any exist first.
Fix by checking first.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538501
@roliveri @hsong-rh please review.
Links