Add MiqRequest factory with MiqApproval #16939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip, test |
4 tasks
|
@miq-bot remove_label wip |
tumido
changed the title
bdunne
reviewed
Feb 8, 2018
spec/factories/miq_request.rb
Outdated
| source { create(:miq_template) } | ||
|
|
||
| after(:create) do |request, evaluator| | ||
| request.miq_approvals << FactoryGirl.create(:miq_approval, :reason => evaluator.reason) |
|
ping, @tumido ? |
tumido
force-pushed
the
miq_requests_scopes
branch
from
52e04ec to
c52b959
Compare
|
Checked commit tumido@c52b959 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@bdunne : is it ok now? |
bdunne
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a MiqRequest factory which has an MiqApproval. Required to test that
report_datais capable to query based onreason.Related: ManageIQ/manageiq-ui-classic#3274