Follow up to update_vm_name for Service template provisioning #16949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
Feb 5, 2018
app/models/miq_provision.rb
Outdated
| @@ -68,7 +68,7 @@ def update_vm_name(new_name, update_request: true) | |||
| options[:vm_target_hostname] = get_hostname(new_name) | |||
|
|
|||
| update_attributes(:description => self.class.get_description(self, new_name), :options => options) | |||
| miq_request.update_description_from_tasks if update_request | |||
| miq_request.update_description_from_tasks if update_request && miq_request.respond_to?(:update_description_from_tasks) | |||
There was a problem hiding this comment.
miq_request.try(:update_description_from_tasks) if update_request?
gmcculloug
force-pushed
the
provision_vm_update_name_service
branch
from
a9b9580
to
ad1e960
Compare
|
Checked commit gmcculloug@ad1e960 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Feb 5, 2018
simaishi
pushed a commit
that referenced
this pull request
Feb 5, 2018
…rvice Follow up to update_vm_name for Service template provisioning (cherry picked from commit cdb1271) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539752
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Feb 5, 2018
…rvice Follow up to update_vm_name for Service template provisioning (cherry picked from commit cdb1271) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539750
|
Gaprindashvili backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…_name_service Follow up to update_vm_name for Service template provisioning (cherry picked from commit cdb1271) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When provisioning a VM as part of a service the miq_provision task gets associated to a
service_template_provision_requestwhich does not have anupdate_description_from_tasksmethod. In this case we want to skip calling theupdate_description_from_tasksmethod if the request object does not expose it.Links
cc @syncrou