Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bind dn and bind pwd on the command line. #16979

Merged

Conversation

jvlcek
Copy link
Member

@jvlcek jvlcek commented Feb 8, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538813

When mode is ldap, bind dn and bind pwd must be provided, either
in the authentication settings or on the command line.

Steps for Testing/QA

  1. Configure MIQLDAP for Mode: LDAP (not Mode: LDAPS)
  2. Do not get groups from LDAP
  3. Manually create users in UPN username format.
  4. Run SSSD conversion
    e.g.:
miqldap_to_sssd -b "cn=Manager,dc=example,dc=com" -p "password" -d "example.com"

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538813

When mode is ldaps certificates must be provided.

When mode is ldap, bind dn and bind pwd must be provided, either
in the authentication settings or on the command line.

e.g: miqldap_to_sssd -b "cn=Manager,dc=example,dc=com" -p "password" -d "example.com"
@jvlcek
Copy link
Member Author

jvlcek commented Feb 8, 2018

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Feb 8, 2018
@jvlcek
Copy link
Member Author

jvlcek commented Feb 8, 2018

@miq-bot add_label gaprindashvili/yes

@jvlcek
Copy link
Member Author

jvlcek commented Feb 8, 2018

@miq-bot add_label authentication

@jvlcek
Copy link
Member Author

jvlcek commented Feb 8, 2018

@miq-bot assign @gtanzillo

@jvlcek
Copy link
Member Author

jvlcek commented Feb 8, 2018

@abellotti and @bdunne Please review. Thank you! JoeV

@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2018

Checked commit jvlcek@6b5df3e with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. ⭐

it 'does not modify basedn_domain if providedn' do
subject = described_class.new(:basedn_domain => "example.com")
it 'when mode is ldap and bind dn is nil raises an error' do
expect(MiqLdapToSssd::LOGGER).to receive(:fatal)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this important to your test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdunne Thank you for the question.

Yes, the bind dn must be provided. It can be provided in 1 of 2 ways.

1 - From the appliance configuration as stored in: Settings.authentication[:bind_dn]

2- If not configured on the appliance the user must provide it as an argument to the miqldap_to_sssd script.

If it is not provided in either of these two ways the miqldap_to_sssd script will raise an error indicating it is missing.

@gtanzillo gtanzillo added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 13, 2018
@gtanzillo gtanzillo merged commit 8aea84d into ManageIQ:master Feb 13, 2018
@jvlcek jvlcek deleted the bz1538813_miqldap_add_binddn_bindpwd branch February 13, 2018 19:02
jvlcek added a commit to jvlcek/manageiq.org that referenced this pull request Feb 14, 2018
Arguments bind-dn and bind-pwd were added to miqldap_to_sssd
in PR: ManageIQ/manageiq#16979

This PR updates the miqldap-to-sssd blog post to include
descriptions of these two new arguments.
simaishi pushed a commit that referenced this pull request Mar 7, 2018
…ndpwd

Add support for bind dn and bind pwd on the command line.
(cherry picked from commit 8aea84d)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552785
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit e4eb8f1bb648d061a45c4f324049577419435ef0
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Tue Feb 13 09:10:17 2018 -0500

    Merge pull request #16979 from jvlcek/bz1538813_miqldap_add_binddn_bindpwd
    
    Add support for bind dn and bind pwd on the command line.
    (cherry picked from commit 8aea84d62b00349a3e9b79926aaa48c37bc087b7)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants