Inventory task #16980
Merged
Inventory task #16980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
inventory_task
branch
3 times, most recently
from
4c09acc
to
c5e6e55
Compare
|
Looks good, the performance enhancement is a nice "extra". |
bdunne
reviewed
Feb 16, 2018
app/models/ext_management_system.rb
Outdated
| ems.try(:containers).try(:count) | ||
| ] | ||
| end | ||
| unless data.empty? |
app/models/ext_management_system.rb
Outdated
| # remove 0's (except for the region) | ||
| data = data.map { |row| row.each_with_index.map { |col, i| i > 0 && col == 0 ? nil : col } } | ||
| data.unshift(%w(region zone kind ems clusters hosts vms storages containers)) | ||
| # remove columns where all values (except for the header) are blank |
There was a problem hiding this comment.
@bdunne this is mostly for containers. yea - others won't be empty
kbrock
commented
Feb 20, 2018
app/models/ext_management_system.rb
Outdated
| # remove 0's (except for the region) | ||
| data = data.map { |row| row.each_with_index.map { |col, i| i > 0 && col == 0 ? nil : col } } | ||
| data.unshift(%w(region zone kind ems clusters hosts vms storages containers)) | ||
| # remove columns where all values (except for the header) are blank |
There was a problem hiding this comment.
@bdunne this is mostly for containers. yea - others won't be empty
kbrock
force-pushed
the
inventory_task
branch
from
6b2066c
to
62b6345
Compare
kbrock
commented
Feb 20, 2018
app/models/ext_management_system.rb
Outdated
| # remove 0's (except for the region) | ||
| data = data.map { |row| row.each_with_index.map { |col, i| i > 0 && col == 0 ? nil : col } } | ||
| data.unshift(%w(region zone kind ems clusters hosts vms storages containers)) | ||
| # remove columns where all values (except for the header) are blank |
There was a problem hiding this comment.
thanks @bdunne - I added specs to exercise this. yea it is mostly for the container column
ugh - I deleted your comment instead of mine
kbrock
force-pushed
the
inventory_task
branch
3 times, most recently
from
a636a7e
to
dc5b5d2
Compare
this outputs general counts for all inventories
also don't display the column if it is empty (or all 0)
kbrock
force-pushed
the
inventory_task
branch
from
dc5b5d2
to
3f2ca09
Compare
|
Some comments on commits kbrock/manageiq@df28c1f~...3f2ca09 lib/tasks/evm.rake
|
|
Checked commits kbrock/manageiq@df28c1f~...3f2ca09 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Feb 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When support wants a quick snapshot of an installation, they just want to know
the general layout for regions, zones, and emses. The numbers for the size of the ems installations as well.
This adds the
evm:inventorytask to display the current inventoryThis also fixed 2 virtual columns that were not executing in sql, but rather in ruby. storages_count is still an N+1 query.