Get targeted arel query automatically #16981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not mergeable. Please rebase and repush. |
Use Reference object as targeted scope, attempting to unify how we deal with targeted refresh, with TODOs for :targeted_arel
Add default targeted arel query. We can build targeted arel automatically in most cases. Since the join is already defined in the ActiveRecord relation.
Allow query to be passed into iterator
Change multiselection from IN to AND and OR, the IN query cannot handle nil values properly.
Use correct array of uniq keys
Remove :targeted_arel queries that can be automatically generated
Reformat exception for automated targeted_arel
User arel to build the multi selection condition, this way comparing different types and comparing nil values is covered. We don't use arel's or, since that causes nesting of the conditions, while we want them flat.
Ladas
force-pushed
the
get_targeted_arel_query_automatically
branch
from
09fe740
to
1153192
Compare
|
Checked commits Ladas/manageiq@d73c39a~...1153192 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to build :targeted_arel queries automatically.
Depends on: