Rename network module to not overrun network class

[d-m-u]

This addresses the concern here wherein ManageIQ::Network is conflicting with ::Network...in particular on the has_many :networks relationship on ExtManagementSystem (or possibly ManageIQ::Providers::InfraManager, which strangely redefines has_many :networks), an issue which was created here

[d-m-u]

@lpichler @gildub @kbrock @jrafanie @gtanzillo @Fryguy

[d-m-u]

@miq-bot add_label bug, core

[miq-bot]

Checked commit d-m-u@a01857a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. ⭐

[kbrock]

👍 LGTM - will need to change the other PRs

[gtanzillo]

@d-m-u This looks good 👍 Are there additional PRs to handle the users of this module?

[jrafanie]

@d-m-u This looks good 👍 Are there additional PRs to handle the users of this module?

Yeah, I see a few. I'll open PRs to fix them.

[jrafanie]

Ok, I think I updated the clients of the old module name. @gildub Please confirm if you think there are others.

Note, I believe we have two modules with the same name now.

https://github.com/ManageIQ/manageiq-network_discovery/blob/master/lib/manageiq/network_discovery.rb

The PROVIDERS_BY_TYPE constant could be a problem since it looks like it's the same name constant now in ManageIQ::NetworkDiscovery and also in ManageIQ::NetworkDiscovery::Discovery. I'm not sure why we have both sets of code now. @gildub any ideas?

https://github.com/ManageIQ/manageiq-network_discovery/blob/3290c1e1c6bf1855eee2d3dbf8a8bd8da83940ba/lib/manageiq/network_discovery.rb#L72-L83

manageiq/lib/manageiq/network_discovery/discovery.rb

Lines 10 to 20 in ca48813

	PROVIDERS_BY_TYPE = {
	:ipmi => "ManageIQ::NetworkDiscovery::IPMI::Discovery",
	:msvirtualserver => "ManageIQ::Providers::Microsoft::Discovery",
	:mswin => "ManageIQ::Providers::Microsoft::Discovery",
	:scvmm => "ManageIQ::Providers::Microsoft::Discovery",
	:openstack_infra => "ManageIQ::Providers::Openstack::Discovery",
	:rhevm => "ManageIQ::Providers::Redhat::Discovery",
	:esx => "ManageIQ::Providers::Vmware::Discovery",
	:virtualcenter => "ManageIQ::Providers::Vmware::Discovery",
	:vmwareserver => "ManageIQ::Providers::Vmware::Discovery"
	}.freeze

[gildub]

@jrafanie, the name space change is to allow a smooth transition to the new discovery modules location, details in ManageIQ/manageiq-network_discovery#8.

There are now effectively 2 modules with the same name and this is going to create an issue with discovery.

The best way to address this is use a different name like ManageIQ::Discovery instead, to avoid conflicts, I'll submit patches consequently.

I believe ultimately having Models STI not allowing to use proper name spaces is something to be addressed because this is a bad structural constraint.

Thank you for your time on this one and sorry for the trouble.

[gildub]

@jrafanie, BTW IPMI is bit of a black sheep because it doesn't have its own space, maybe one day it will ;)

[gildub]

@jrafanie, ManageIQ/manageiq-providers-vmware#183 is the last one

[gildub]

@miq-bot add_label gaprindashvili/yes

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 1a2bf02ba3c467a1a506cef8e6d5348631f1b0fe
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Tue Feb 13 13:28:26 2018 -0500

    Merge pull request #16994 from d-m-u/fixing_network_module_naming
    
    Rename network module to not overrun network class
    (cherry picked from commit ca488135596eb353985bbfe9496f3506d0411fb6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552665