Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding classifications for V2V #17000

Merged

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2018

When transforming a VM from on provider to another, we configure some machines as transformation hosts. This consists in installing some mandatory packages, such as virt-v2v, nbdkit-plugin-vddk, etc..., as well as creating some filesystem tree where the transformation temporary files will be stored. This is done using Ansible playbooks and on enablement / disablement, we set tags on the transformation hosts.

Currently, we use two tags:

  • v2v_transformation_host that is a boolean to identify the machine as a transformation host
  • v2v_transformation_method that is a multi-value tag to store the available transformation methods on this host, i.e. the ones deployed via the playbook.

@ghost ghost changed the title Adding classifications for V2V [WIP] Adding classifications for V2V Feb 14, 2018
@ghost
Copy link
Author

ghost commented Feb 14, 2018

@miq-bot add_label transformation

@ghost ghost changed the title [WIP] Adding classifications for V2V Adding classifications for V2V Feb 14, 2018
@miq-bot miq-bot removed the wip label Feb 14, 2018
@gmcculloug gmcculloug self-requested a review February 14, 2018 21:08
:syntax: string
:show: true
:name: v2v_transformation_host
:example_text: The fact that the Transformation Host role is enabled for V2V.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: Transformation Host role enabled for V2V.

:syntax: string
:show: true
:name: v2v_transformation_method
:example_text: The transformation methods supported for V2V.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: Transformation methods supported for V2V.

@gmcculloug
Copy link
Member

@fdupont-redhat Please squash this PR down to a single commit. There is no reason to retain to separate commits in this case.

@ghost ghost force-pushed the v2v_transformation_host_tags branch from 362400b to 178a2d8 Compare February 15, 2018 13:29
@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2018

Checked commit fabiendupont@178a2d8 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@gtanzillo gtanzillo added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 15, 2018
@gtanzillo gtanzillo merged commit 69ca707 into ManageIQ:master Feb 15, 2018
simaishi pushed a commit that referenced this pull request May 31, 2018
…_tags

Adding classifications for V2V
(cherry picked from commit 69ca707)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 56a74de23f4f06cb0d12b9b83e667900cdf5898b
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Feb 15 09:14:26 2018 -0500

    Merge pull request #17000 from fdupont-redhat/v2v_transformation_host_tags
    
    Adding classifications for V2V
    (cherry picked from commit 69ca707f77f47ce8d8322229e498fccd7478f808)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants