Group chargeback report for VMs by tenant #17002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler Cannot apply the following label because they are not recognized: gaprindashvilli/yes |
This was referenced Feb 14, 2018
|
@miq-bot add_label gaprindashvili/yes |
We have consumption blocks with set of metric rollups. This set belongs to the tenant. When we do max on this set we will get just max and it doesn't get max value for each VM. It should take max value for each VM and then sum these maxes. Example: (VM1 and VM1 are in one tenant TI) VM1: 2 Allocated Cores (Max) VM2: 3 Allocated Cores (Max) Report grouped bytenant: Tenant: 5 Allocated Cores (2 + 3 ) - is sum of maxes And costs are derived from this values. For avg: there is no such issue: VM1: 2 Allocated Cores (Avg) (Cores 3 MetricRollups: 1, 2, 3) VM2: 3 Allocated Cores (Avg)(Cores in 3 MetricRollups:2, 3, 4) Report grouped bytenant: Tenant: 5 Allocated Cores (2.5) (3 + 2) / 2 = 2.5 (1 + 2 + 3 + 2 + 3 + 4) = 2,5 It is same, AVG method don't have such issue.
lpichler
force-pushed
the
group_chargeback_report_for_vm_report_by_tenant
branch
from
d023b6e
to
71fea20
Compare
|
Checked commits lpichler/manageiq@3525cfc~...71fea20 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2018
…m_report_by_tenant Group chargeback report for VMs by tenant (cherry picked from commit 0d23948) https://bugzilla.redhat.com/show_bug.cgi?id=1552796
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group by tenant for chargeback|metering Vm reports manageiq-ui-classic#3380
Add possibility for grouping chargeback reports by tenant. Row with tenant on report considers VMs related to the tenant.
Example:
report grouped by VMs (VM1,2 are from tenant T1)
then report grouped by Tenants (VM1,2 are from tenant T1)
Measure values and costs from VMs are summed up for their tenants on report group by tenant.
Report Result
[FROM UI PR] How to select group by tenant in report definition
Links
Group by tenant for chargeback|metering Vm reports manageiq-ui-classic#3380
@miq-bot assign @gtanzillo
@miq-bot add_label enhancement, gaprindashvilli/yes