-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in help message #17009
Fix errors in help message #17009
Conversation
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1545861 Update bind-pwd description in help message Change basedn-domain to domain Fix spelling error coversion to conversion for skip-post-conversion-userid-change
@miq-bot add_label bug authentication gaprindashvili/yes |
@miq-bot assign @abellotti |
@jvlcek Cannot apply the following label because they are not recognized: bug authentication gaprindashvili/yes |
@djberg96 Here is the code change PR that goes with the review comments you had provided for the blog updates in PR: ManageIQ/manageiq.org#642 Thank you for the extra 👀 ! |
@miq-bot add_label bug |
@miq-bot add_label authentication |
@miq-bot add_label gaprindashvili/yes |
Checked commit jvlcek@8d5fcab with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Thanks @jvlcek for updating this, LGTM!! 👍 |
@jvlcek 👍 |
Fix errors in help message (cherry picked from commit 54d4f02) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552791
Gaprindashvili backport details:
|
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1545861
The help message for miqldap_to_sssd had three issue that this PR addresses.
Update bind-pwd description in help message
Change basedn-domain to domain
Fix spelling error coversion to conversion for skip-post-conversion-userid-change
Steps for Testing/QA
Simply run
miqldap_to_sssd --help
the output should look like the following: