Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in help message #17009

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

jvlcek
Copy link
Member

@jvlcek jvlcek commented Feb 15, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1545861

The help message for miqldap_to_sssd had three issue that this PR addresses.

Update bind-pwd description in help message
Change basedn-domain to domain
Fix spelling error coversion to conversion for skip-post-conversion-userid-change

Steps for Testing/QA

Simply run miqldap_to_sssd --help the output should look like the following:

miq> miqldap_to_sssd --help
Usage: ruby tools/miqldap_to_sssd.rb [options]
  -d, --domain=<s>                           The domain name for the Base DN, e.g. example.com
  -b, --bind-dn=<s>                          The Bind DN, credential to use to authenticate against LDAP e.g.
                                             cn=Manager,dc=example,dc=com
  -p, --bind-pwd=<s>                         The password for the Bind DN.
  -c, --tls-cacert=<s>                       Path to certificate file
  -n, --only-change-userids                  normalize the userids then exit
  -s, --skip-post-coversion-userid-change    Do the MiqLdap to SSSD conversion but skip the normalizing of the userids
  -h, --help                                 Show this message

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1545861

Update bind-pwd description in help message
Change basedn-domain to domain
Fix spelling error coversion to conversion for skip-post-conversion-userid-change
@jvlcek
Copy link
Member Author

jvlcek commented Feb 15, 2018

@miq-bot add_label bug authentication gaprindashvili/yes

@jvlcek
Copy link
Member Author

jvlcek commented Feb 15, 2018

@miq-bot assign @abellotti

@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2018

@jvlcek Cannot apply the following label because they are not recognized: bug authentication gaprindashvili/yes

@jvlcek
Copy link
Member Author

jvlcek commented Feb 15, 2018

@djberg96 Here is the code change PR that goes with the review comments you had provided for the blog updates in PR: ManageIQ/manageiq.org#642

Thank you for the extra 👀 !

@jvlcek
Copy link
Member Author

jvlcek commented Feb 15, 2018

@miq-bot add_label bug

@jvlcek
Copy link
Member Author

jvlcek commented Feb 15, 2018

@miq-bot add_label authentication

@jvlcek
Copy link
Member Author

jvlcek commented Feb 15, 2018

@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2018

Checked commit jvlcek@8d5fcab with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 0 offenses detected
Everything looks fine. 👍

@abellotti
Copy link
Member

Thanks @jvlcek for updating this, LGTM!! 👍

@abellotti abellotti added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 15, 2018
@abellotti abellotti merged commit 54d4f02 into ManageIQ:master Feb 15, 2018
@djberg96
Copy link
Contributor

@jvlcek 👍

simaishi pushed a commit that referenced this pull request Mar 7, 2018
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 72f37b935dd4fde62b0ec7e3d42a32f0c826feba
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Thu Feb 15 16:51:03 2018 -0500

    Merge pull request #17009 from jvlcek/bz1545861_miqladp_to_sssd_help
    
    Fix errors in help message
    (cherry picked from commit 54d4f028a9b889348789499d7de558d2602edc74)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552791

@jvlcek jvlcek deleted the bz1545861_miqladp_to_sssd_help branch May 1, 2018 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants