Add InventoryObject interface automatically #17010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add InventoryObject interface automatically, without need to specify it in :inventory_object_attributes
Ladas
commented
Feb 20, 2018
| return [] unless model_class | ||
|
|
||
| # Get all writers of a model | ||
| @allowed_writers ||= (model_class.new.methods - Object.methods).grep(/^[\w]+?\=$/) |
There was a problem hiding this comment.
@agrare do you know nicer way of doing this?
Add missing YARD docs for InventoryObject
|
I can't think of a better way to do this but looks good to me |
|
Checked commits Ladas/manageiq@1bff320~...68d996c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Apr 18, 2018
|
Ovirt and Amazon tests pass locally with this changeset applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add InventoryObject interface automatically, without need to
specify it in :inventory_object_attributes