Add delete notification types for Tenant #17011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not mergeable. Please rebase and repush. |
mansam
reviewed
Mar 2, 2018
db/fixtures/notification_types.yml
Outdated
| @@ -254,6 +254,16 @@ | |||
| :expires_in: 24.hours | |||
| :level: :error | |||
| :audience: global | |||
| - :name: cloud_tenant_delete_success | |||
| :message: 'Deleting Cloud Tenant %{subject} completed successfully' | |||
There was a problem hiding this comment.
I'd recommend adding a "." at the end of this line so that the punctuation matches other messages, but otherwise LGTM.
andyvesel
force-pushed
the
add_notification
branch
from
a310875
to
0a12f0a
Compare
|
Checked commits andyvesel/manageiq@0a12f0a~...6712abd with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@mansam could you review? |
|
@agrare could you review? |
agrare
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notification types
cloud_tenant_delete_successandcloud_tenant_delete_successRelated PR: ManageIQ/manageiq-providers-openstack#231
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1448683