Add lans as a virtual relationship to ems_cluster #17019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Feb 19, 2018
app/models/ems_cluster.rb
Outdated
| @@ -230,6 +232,12 @@ def memory_reserve | |||
| get_reserve(:memory_reserve) | |||
| end | |||
|
|
|||
| def lans | |||
There was a problem hiding this comment.
should we move this to AggregationMixin together with the existing all_storages?
Possibly add a spec for it?
|
@agrare please review |
jntullo
force-pushed
the
ems_cluster_lans
branch
from
a4cc28e
to
33e034c
Compare
agrare
reviewed
Feb 19, 2018
| def lans | ||
| hosts = all_hosts | ||
| MiqPreloader.preload(hosts, :lans) | ||
| hosts.collect(&:lans).flatten.compact.uniq |
There was a problem hiding this comment.
How about hosts.flat_map(&:lans).compact.uniq instead of collect + flatten?
Lans need to be exposed via the API for the creation of transformation mappings. By adding this virtual relationship, they are able to be queried via `/api/clusters/:id?attributes=lans` There will be a lans collection added to the API in a follow-up PR
jntullo
force-pushed
the
ems_cluster_lans
branch
from
33e034c
to
61ce705
Compare
|
Checked commit jntullo@61ce705 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
27 tasks
|
@miq-bot add_label gaprindashvili/yes Needed by ManageIQ/manageiq-api#325 for gaprindashvili v2v support |
simaishi
pushed a commit
that referenced
this pull request
May 29, 2018
Add lans as a virtual relationship to ems_cluster (cherry picked from commit 4e212e4)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lans need to be exposed via the API for the creation of transformation mappings. By adding this virtual relationship, they are able to be queried via
/api/clusters/:id?attributes=lanscc: @bzwei, @priley86
@miq-bot assign @gtanzillo
@miq-bot add_label transformation