Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title display message and factory for Vault Credentials #17048

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Add title display message and factory for Vault Credentials #17048

merged 2 commits into from
Feb 28, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Feb 26, 2018 •
edited
Loading

@lgalis lgalis changed the title [WIP] Update to Vault credentials title message Add title display message for Vault Credential Feb 26, 2018
@lgalis lgalis mentioned this pull request Feb 26, 2018
Merged
@lgalis lgalis force-pushed the vault_credential_title_update branch from 27b3aa5 to 8e4ec53 Compare February 27, 2018 05:47
@lgalis lgalis changed the title Add title display message for Vault Credential Add title display message and factory for Vault Credentials Feb 27, 2018
@lgalis lgalis force-pushed the vault_credential_title_update branch from 8e4ec53 to 01d2030 Compare February 27, 2018 15:20
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2018

Checked commits lgalis/manageiq@8aa626b~...01d2030 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@lgalis
Copy link
Contributor Author

lgalis commented Feb 27, 2018 •
edited
Loading

@miq-bot add_label enhancement, gaprindashvili/no

@lgalis
Copy link
Contributor Author

lgalis commented Feb 27, 2018

@dclarizio or @gmcculloug - please review

@bdunne bdunne merged commit 65d2667 into ManageIQ:master Feb 28, 2018
@bdunne bdunne added this to the Sprint 81 Ending Mar 12, 2018 milestone Feb 28, 2018
@bdunne bdunne assigned bdunne and unassigned gmcculloug Feb 28, 2018
simaishi pushed a commit that referenced this pull request Mar 26, 2018
@bdunne @simaishi
Merge pull request #17048 from lgalis/vault_credential_title_update
3e48743 
Add title display message and factory for Vault Credentials
(cherry picked from commit 65d2667)

https://bugzilla.redhat.com/show_bug.cgi?id=1559479
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 3e487437d10a3e608fb00e73d62b24e0071b0b7b
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Wed Feb 28 10:56:36 2018 -0500

    Merge pull request #17048 from lgalis/vault_credential_title_update
    
    Add title display message and factory for Vault Credentials
    (cherry picked from commit 65d2667358ed493718f926fa6d84e1c408eaee35)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1559479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bdunne bdunne

Labels
automate enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lgalis @miq-bot @simaishi @bdunne @gmcculloug @dclarizio