Make Taggable of AutomationManager's authentications/playbooks/repos

[jameswnl]

https://bugzilla.redhat.com/show_bug.cgi?id=1526219
https://bugzilla.redhat.com/show_bug.cgi?id=1526218
https://bugzilla.redhat.com/show_bug.cgi?id=1526217

[jameswnl]

@miq-bot add_labels enhancement, providers/ansible_tower

[miq-bot]

Checked commit jameswnl@8ab4bbf with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

[agrare]

@jameswnl probably should add acts_as_miq_taggable to the base models not just the ansible ones

[jameswnl]

@agrare I actually thought about adding to the base models. But the BZs ask for scope of Ansible. Now I've added to AutomationManager.

I don't have specific reason opposing to tag the base models. But If we do want to, essentially we are making all Authentication taggable. Is that Ok?

[agrare]

@jameswnl okay that's fine with me, @h-kataria do you know if not having these at the base model will impact the UI RBAC work?

[h-kataria]

@agrare @jameswnl these changes don't look harmful to me, we will need these to turn on Tagging support in UI for these models.

[agrare]

Thanks @h-kataria

[jameswnl]

@h-kataria what abstraction level does UI call on? Does UI call on ManageIQ::Providers::AutomationManager? Or it call on the base models?

[simaishi]

gaprindashvili/yes ?

[jameswnl]

@miq-bot add_labels gaprindashvili/yes

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 71b010697829b6ba2451b14dcae1a9ab2d8987c8
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Feb 27 14:54:27 2018 -0500

    Merge pull request #17049 from jameswnl/taggable
    
    Make Taggable of AutomationManager's authentications/playbooks/repos
    (cherry picked from commit dd90df8863441ef705f6dfc1e6f3f0b338ef58a5)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553393
    https://bugzilla.redhat.com/show_bug.cgi?id=1553768
    https://bugzilla.redhat.com/show_bug.cgi?id=1553396

[hstastna]

@jameswnl I had to move acts_as_miq_taggable to base classes to fix errors when editing Ansible Credential/Repository (#17244)