Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config file to represent Rack in the UI #17078

Merged
merged 1 commit into from
May 17, 2018
Merged

Config file to represent Rack in the UI #17078

merged 1 commit into from
May 17, 2018

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Mar 2, 2018 •
edited
Loading

This PR is able to:

  • Add config files to represent a Rack in the UI

Depends on: #16853 [ Merged ]
Related to: ManageIQ/manageiq-ui-classic#3503

@felipedf felipedf changed the title Rack ui [WIP] Config file to represent Rack in the UI Mar 2, 2018
@miq-bot miq-bot added the wip label Mar 2, 2018
@felipedf felipedf mentioned this pull request Mar 8, 2018
Merged
@saulotoledo
Copy link
Member

saulotoledo commented Mar 14, 2018 •
edited
Loading

@felipedf It is a good idea to update the permissions for the roles (just by matching the identifiers and the user roles). I suggest using the same permissions as for physical servers (@rodneyhbrown7, could you confirm that?). You can use the following PRs as a guide (the second one has some entries that are missing in the first one; be sure to check both of them):

https://github.com/ManageIQ/manageiq/pull/16637/files
https://github.com/ManageIQ/manageiq/pull/16958/files

@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2018

This pull request is not mergeable. Please rebase and repush.

@felipedf felipedf force-pushed the rack_ui branch 2 times, most recently from 4b79c81 to 01734cf Compare April 5, 2018 12:47
@felipedf
Copy link
Member Author

felipedf commented Apr 5, 2018

#16853 was merged

@felipedf felipedf changed the title [WIP] Config file to represent Rack in the UI Config file to represent Rack in the UI Apr 5, 2018
@felipedf felipedf force-pushed the rack_ui branch 4 times, most recently from 914051b to c4d388f Compare April 24, 2018 13:59
@felipedf
Copy link
Member Author

@miq-bot assign @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented May 3, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented May 14, 2018

This pull request is not mergeable. Please rebase and repush.

@felipedf felipedf force-pushed the rack_ui branch 2 times, most recently from 4582c1c to 8e3d410 Compare May 17, 2018 14:43
@agrare agrare closed this May 17, 2018
@agrare agrare reopened this May 17, 2018
@agrare agrare assigned agrare and unassigned martinpovolny May 17, 2018
@miq-bot
Copy link
Member

miq-bot commented May 17, 2018

Checked commit felipedf@8e3d410 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@agrare agrare merged commit 1eb6ee1 into ManageIQ:master May 17, 2018
@agrare agrare added this to the Sprint 86 Ending May 21, 2018 milestone May 17, 2018
@felipedf felipedf deleted the rack_ui branch May 17, 2018 17:21
@mzazrivec mzazrivec mentioned this pull request Jun 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@agrare agrare

Labels
enhancement providers/physical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felipedf @saulotoledo @miq-bot @martinpovolny @agrare