Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uniqueness of service for generation chargeback report for SSUI #17082

Merged
merged 1 commit into from
Mar 5, 2018

Commits on Mar 5, 2018

  1. Add uniqueness for generation chargeback report for SSUI

    Chargeback report in summary dashboard screen is calculated
    from data from this API request:
    /api/services?expand=resources&filter[]=service_id%3Dnil&attributes=chargeback_report
    
    and this request is returing data from each service
    
    service1:
      chargeback_data_for_service_my_service
    
    service2:
      chargeback_data_for_service_my_service
    
    service3:
      chargeback_data_for_service_my_service
    
    but for each service has been used
    same name of report because Services could be
    named by same name.
    
    So when there is generated result for service3 and
    this result is empty then in final API request
    will have all services empty result as well because
    report results from service1 and 2 have been
    overwriten by empty result from service 3 -
    thanks to the distiguishing by just name.
    
    So I am adding Service#id for distiguishing and
    ensuring uniqueness.
    lpichler committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    dfed1c2 View commit details
    Browse the repository at this point in the history