Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagging feature for Ansible Repositories #17083

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

hstastna
Copy link

@hstastna hstastna commented Mar 5, 2018

More in: https://bugzilla.redhat.com/show_bug.cgi?id=1526217
UI PR: ManageIQ/manageiq-ui-classic#3513

This PR is a part of making tagging support work in Ansible Repositories, and also with another PR in UI repo, completes adding tagging support for Ansible Repos (in Automation > Ansible > Repositories). It needs to be merged first (before the UI, to remain everything work properly).

@hstastna
Copy link
Author

hstastna commented Mar 5, 2018

@miq-bot add_label blocker, enhancement, gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2018

Checked commit hstastna@b78f78f with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@hstastna hstastna changed the title Add tagging feature for Ansible Repositories [WIP] Add tagging feature for Ansible Repositories Mar 5, 2018
@miq-bot miq-bot added the wip label Mar 5, 2018
@hstastna hstastna changed the title [WIP] Add tagging feature for Ansible Repositories Add tagging feature for Ansible Repositories Mar 6, 2018
@miq-bot miq-bot removed the wip label Mar 6, 2018
@JPrause
Copy link
Member

JPrause commented Mar 6, 2018

@hstastna who can review this blocker PR?

@hstastna
Copy link
Author

hstastna commented Mar 6, 2018

@h-kataria @martinpovolny Could anyone of you review this PR? The PR is an important part of making tagging support work in Ansible Repositories (the UI part also already done). Thanks! 👍

@h-kataria h-kataria added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 6, 2018
@h-kataria h-kataria merged commit 2e5f2d6 into ManageIQ:master Mar 6, 2018
@hstastna
Copy link
Author

hstastna commented Mar 6, 2018

UI PR: ManageIQ/manageiq-ui-classic#3513

simaishi pushed a commit that referenced this pull request Mar 9, 2018
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2018

Gaprindashvili backport details:

$ git log -1
commit 8dae52276496c0f250e4e2b821e9609e8c8837d0
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Mar 6 14:18:07 2018 -0500

    Merge pull request #17083 from hstastna/Add_RBAC_Tagging_Ansible_Repos
    
    Add tagging feature for Ansible Repositories
    (cherry picked from commit 2e5f2d6bf4845b38d9a03a6113936b475bb23b24)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants