Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete #retire_now since it has been moved to shared code #17095

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Delete #retire_now since it has been moved to shared code #17095

merged 1 commit into from
Mar 6, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Mar 6, 2018

The code has been moved to another repository so it can be safely deleted.

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468635

Depends on ManageIQ/manageiq-providers-ansible_tower#66

@bzwei bzwei mentioned this pull request Mar 6, 2018
Merged
@bzwei
Copy link
Contributor Author

bzwei commented Mar 6, 2018

@miq-bot add_label bug
@miq-bot assign @gmcculloug
@tinaafitz please review

@miq-bot miq-bot added the bug label Mar 6, 2018
@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2018

Checked commit bzwei@6f62e35 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug gmcculloug merged commit dcc13f3 into ManageIQ:master Mar 6, 2018
@gmcculloug gmcculloug added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 6, 2018
@bzwei bzwei deleted the tower_job_retirement branch March 6, 2018 20:00
@simaishi
Copy link
Contributor

@bzwei @gmcculloug Can this be gaprindashvili/yes?

@bzwei
Copy link
Contributor Author

bzwei commented Jul 11, 2018

yes

simaishi pushed a commit that referenced this pull request Jul 12, 2018
@gmcculloug @simaishi
Merge pull request #17095 from bzwei/tower_job_retirement
8254a91 
Delete #retire_now since it has been moved to shared code
(cherry picked from commit dcc13f3)

https://bugzilla.redhat.com/show_bug.cgi?id=1600670
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 8254a91b2a5a4d61506d801ee2410b897d2e3424
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Mar 6 11:54:48 2018 -0500

    Merge pull request #17095 from bzwei/tower_job_retirement
    
    Delete #retire_now since it has been moved to shared code
    (cherry picked from commit dcc13f367f21e30d9575552452173fe356b06fc9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1600670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzwei @miq-bot @simaishi @gmcculloug