Fix ambiguous created_recently scope #17102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
approved these changes
Mar 7, 2018
spec/models/miq_request_spec.rb
Outdated
|
|
||
| def approvals | ||
| reason.collect do |r| | ||
| FactoryGirl.create(:miq_approval, :approver => fred, :reason => r, :stamper => barney, :stamped_on => Time.now) |
There was a problem hiding this comment.
please do update this Time.now to Time.now.utc
When used in combination with `with_reason_like` scope, the scope `create_recently` becomes ambiguous.
tumido
force-pushed
the
fix_miq_request_scope
branch
from
804ba4e
to
e664d21
Compare
|
Checked commit tumido@e664d21 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used in combination with
with_reason_likescope, the scopecreate_recentlybecomes ambiguous.Related (fixes issue introduced by): #16843
@miq-bot add_label bug, gaprindashvili/no
@martinpovolny, some love for you ⬆️ 🎉