Stop unbounded growth of targets #17144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop unbounded growth of targets Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1549123
Ladas
force-pushed
the
stop_unbounded_growth_of_queued_targets
branch
from
89e2f68
to
a22c7af
Compare
agrare
reviewed
Mar 13, 2018
app/models/ems_refresh.rb
Outdated
| manager_refresh_targets.uniq! { |_, value| value.values_at(:manager_id, :association, :manager_ref) } | ||
|
|
||
| targets = application_record_targets + manager_refresh_targets | ||
| end |
There was a problem hiding this comment.
Can you move this to a private helper method? queue_merge is long enough already :/
Extract uniq_targets method
|
Checked commits Ladas/manageiq@a22c7af~...7473870 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop unbounded growth of targets
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1549123