Use vm_ems_ref to reconnect events #17145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
bz_1428797_use_vm_ems_ref_for_reconnect_events
branch
from
d6c9e8c
to
b5a7266
Compare
Events delivered early in a VM's lifecycle often do not contain the vmPathName yet and therefore cannot be connected to VMs which are saved after the events are processed. It is much more reliable to use the VM's ems_ref since that is available in all tasks and events except the initial CreateVM_Task/CloneVM_Task (since the target VM hasn't been created yet it isn't possible to link these to a VM anyway). Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1428797
agrare
force-pushed
the
bz_1428797_use_vm_ems_ref_for_reconnect_events
branch
from
b5a7266
to
1cfd5eb
Compare
|
Checked commit agrare@1cfd5eb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Thanks @kbrock ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events delivered early in a VM's lifecycle often do not contain the
vmPathName yet and therefore cannot be connected to VMs which are saved
after the events are processed. It is much more reliable to use the
VM's ems_ref since that is available in all tasks and events except the
initial CreateVM_Task/CloneVM_Task (since the target VM hasn't been
created yet it isn't possible to link these to a VM anyway).
https://bugzilla.redhat.com/show_bug.cgi?id=1428797
Depends on:
ManageIQ/manageiq-schema#176