Add encryption key validation rake task #17149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This task will use the currently configured encryption key to attempt to decrypt the seeded values from the miq_datbases entry. If the database is not migrated and seeded yet, it will return true https://bugzilla.redhat.com/show_bug.cgi?id=1544854
carbonin
force-pushed
the
encryption_key_validation
branch
from
268b7ee
to
6fa1bf5
Compare
|
Some comments on commits carbonin/manageiq@9bd0f5d~...6fa1bf5 lib/tasks/evm.rake
|
|
Checked commits carbonin/manageiq@9bd0f5d~...6fa1bf5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
reviewed
Mar 13, 2018
| @@ -56,6 +56,12 @@ namespace :evm do | |||
| puts inventory.tableize if inventory.present? | |||
| end | |||
|
|
|||
| desc "Determine if the configured encryption key is valid" | |||
| task :validate_encryption_key => :environment do | |||
There was a problem hiding this comment.
Would loading environment as a prerequisite possibly blow up due to a bad encryption key before we get to this task?
There was a problem hiding this comment.
I can run bundle exec rake environment with the wrong key, so I think this is fine.
|
Put the wrong BZ link here ... oops The correct one is https://bugzilla.redhat.com/show_bug.cgi?id=1519312 |
|
Updated in description as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task will use the currently configured encryption key to
attempt to decrypt the seeded values from the miq_databases entry.
If the database is not migrated and seeded yet, it will return true
https://bugzilla.redhat.com/show_bug.cgi?id=1519312