Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vault credential support to Ansible playbook service template. #17184

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Add vault credential support to Ansible playbook service template. #17184

merged 1 commit into from
Mar 21, 2018

Conversation

lfu
Copy link
Member

@lfu lfu commented Mar 21, 2018 •
edited
Loading

Backend support for ManageIQ/manageiq-ui-classic#3468.

@miq-bot assign @gmcculloug
@miq-bot add_label enhancement, services

Part of https://bugzilla.redhat.com/show_bug.cgi?id=1526048 required to get to Embedded Ansible 3.2.x
Part of https://bugzilla.redhat.com/show_bug.cgi?id=1561116 required to get to Embedded Ansible 3.2.x

cc @syncrou

@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2018

Checked commit lfu@635d8ca with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug gmcculloug requested a review from syncrou March 21, 2018 18:24
syncrou
syncrou approved these changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@syncrou syncrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gmcculloug gmcculloug merged commit f2ad37a into ManageIQ:master Mar 21, 2018
@gmcculloug gmcculloug added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 21, 2018
@jameswnl jameswnl mentioned this pull request Mar 21, 2018
Closed
21 tasks
simaishi pushed a commit that referenced this pull request Mar 26, 2018
@gmcculloug @simaishi
Merge pull request #17184 from lfu/ansible_vault_credential
796dc34 
Add vault credential support to Ansible playbook service template.
(cherry picked from commit f2ad37a)

https://bugzilla.redhat.com/show_bug.cgi?id=1559479
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 796dc34f4b85a6525b1f1032498af4901b6bd735
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Mar 21 15:18:20 2018 -0400

    Merge pull request #17184 from lfu/ansible_vault_credential
    
    Add vault credential support to Ansible playbook service template.
    (cherry picked from commit f2ad37ab639e18bd6d83cf6689a4ed309abd69e5)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1559479

@lfu lfu deleted the ansible_vault_credential branch September 29, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug approved these changes

@syncrou syncrou syncrou approved these changes

Assignees

@gmcculloug gmcculloug

Labels
enhancement gaprindashvili/backported lifecycle/services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lfu @miq-bot @simaishi @syncrou @gmcculloug