Add case insensitivity when validating uniqueness of name of new group/role #17197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstastna
force-pushed
the
Duplicate_RBAC_Role_Group_names_capitalization
branch
from
dd99d20
to
5dcb11c
Compare
added 2 commits
March 23, 2018 23:54
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537171 Add case insensitivity when validating uniqueness of name of a new group within a region.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537171 Add case insensitivity when validating uniqueness of the name of a new role, when creating a new role under Configuration > Access Control > Roles.
hstastna
force-pushed
the
Duplicate_RBAC_Role_Group_names_capitalization
branch
from
5dcb11c
to
4ddb142
Compare
|
Checked commits hstastna/manageiq@db23d63~...4ddb142 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label bug |
|
@miq-bot assign @gtanzillo |
simaishi
pushed a commit
that referenced
this pull request
Mar 27, 2018
…es_capitalization Add case insensitivity when validating uniqueness of name of new group/role (cherry picked from commit ad57f99) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561076
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 9, 2018
…es_capitalization Add case insensitivity when validating uniqueness of name of new group/role (cherry picked from commit ad57f99) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561077
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…roup_names_capitalization Add case insensitivity when validating uniqueness of name of new group/role (cherry picked from commit ad57f99) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537171
Add case insensitivity when validating uniqueness of the name of a new group within a region.
Add case insensitivity when validating uniqueness of the name of a new role + little refactoring.
After: (different capitalization but the same names => flash messages)
