Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup order of model request types #17206

Merged

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Mar 27, 2018

The model request types ought to be alphabetized.
i can haz alphabet

@d-m-u
Copy link
Contributor Author

d-m-u commented Mar 27, 2018

@bdunne
@miq-bot add_label cleanup

@d-m-u d-m-u force-pushed the ordering_models_in_miq_request_more_rightly branch from 26e01de to 3bd892d Compare March 27, 2018 12:27
@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2018

Checked commit d-m-u@3bd892d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@gmcculloug gmcculloug self-assigned this Mar 27, 2018
@gmcculloug gmcculloug requested a review from bdunne March 27, 2018 12:40
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯 🎉 😄

@bdunne bdunne merged commit f0ad654 into ManageIQ:master Mar 27, 2018
@bdunne bdunne assigned bdunne and unassigned gmcculloug Mar 27, 2018
@d-m-u d-m-u deleted the ordering_models_in_miq_request_more_rightly branch March 27, 2018 14:02
@gmcculloug gmcculloug added this to the Sprint 83 Ending Apr 9, 2018 milestone Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants