Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ownership for MiqRequest in RBAC #17208

Merged

Commits on Mar 27, 2018

  1. Rename method

    from get_self_service_objects to
    self_service_ownership_scope
    lpichler committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    e163934 View commit details
    Browse the repository at this point in the history
  2. Use conjunction(De-Morgan rules)

    ¬(A∨B∨C)=¬A∧¬B∧¬C
    
    return nil if miq_group.nil? || !miq_group.self_service? || !(klass < OwnershipMixin)
    
    to
    
    return unless !(miq_group.nil? || !miq_group.self_service? || !(klass < OwnershipMixin))
    
    to
    
    return unless !miq_group.nil? && !!miq_group.self_service? && !!(klass < OwnershipMixin)
    
    to
    
    return unless miq_group.present? && miq_group.self_service? && klass < OwnershipMixin
    
    to(add to method)
    
    return nil unless self_service_ownership_scope?(miq_group, klass)
    lpichler committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    4a50b5a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. Configuration menu
    Copy the full SHA
    80f4f10 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb98fea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    97324fc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5c6b8f9 View commit details
    Browse the repository at this point in the history