Adding roles, filters and configurations for Physical Switches support #17216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulotoledo
changed the title
saulotoledo
changed the title
|
@agrare, @rodneyhbrown7, this can be reviewed after merging #16948. |
saulotoledo
force-pushed
the
add_switches_config
branch
from
75699f9
to
245a28f
Compare
|
This pull request is not mergeable. Please rebase and repush. |
saulotoledo
force-pushed
the
add_switches_config
branch
2 times, most recently
from
a738550
to
9b8f07f
Compare
saulotoledo
force-pushed
the
add_switches_config
branch
5 times, most recently
from
bf0ce3b
to
cdaa8d8
Compare
saulotoledo
changed the title
saulotoledo
force-pushed
the
add_switches_config
branch
2 times, most recently
from
ba57225
to
4f9c1de
Compare
|
@agrare, could you take a look on this PR? |
saulotoledo
force-pushed
the
add_switches_config
branch
from
4f9c1de
to
d278d6b
Compare
|
Checked commit saulotoledo@d278d6b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Not sure where to start on this one but I think @martinpovolny is the one to look at user/roles changes |
|
To test (to see the changes in the feature tree) this PR has to be tested together with ManageIQ/manageiq-ui-classic#3699 Having done so I see no problems --> merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds roles, filters and configurations for Physical Switches support in the UI.
Depends on: