Fix update_attributes to take right number of args #17235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
commented
Mar 29, 2018
app/models/miq_retire_task.rb
Outdated
| @@ -44,7 +44,7 @@ def deliver_to_automate(req_type = request_type, zone = nil) | |||
| :args => [args], | |||
| :role => 'automate', | |||
| :zone => options.fetch(:miq_zone, zone), | |||
| :tracking_label => my_task_id, | |||
| # :tracking_label => my_task_id, | |||
There was a problem hiding this comment.
@tinaafitz can I take out this id? or do I need it?
There was a problem hiding this comment.
call it tracking_label_id
d-m-u
force-pushed
the
fixing_vm_request_retirement
branch
2 times, most recently
from
22567e3
to
0cd8455
Compare
d-m-u
changed the title
d-m-u
force-pushed
the
fixing_vm_request_retirement
branch
from
0cd8455
to
61501b3
Compare
|
Checked commit d-m-u@61501b3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
tinaafitz
approved these changes
Apr 3, 2018
|
@miq-bot add_label retirement |
bdunne
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM retirement as a request needs these two changes in order to work as expected.